summaryrefslogtreecommitdiffstats
path: root/include/query
diff options
context:
space:
mode:
authorDouglas Rumbaugh <dbr4@psu.edu>2024-01-17 18:22:00 -0500
committerDouglas Rumbaugh <dbr4@psu.edu>2024-01-17 18:22:00 -0500
commit138c793b0a58577713d98c98bb140cf1d9c79bee (patch)
tree921197e2ba521704cb379ac8069189e70f8dee3d /include/query
parent2117935e85412f3733ee0bcb1830c7fd0b129b29 (diff)
downloaddynamic-extension-138c793b0a58577713d98c98bb140cf1d9c79bee.tar.gz
Multiple concurrency bug fixes
A poorly organized commit with fixes for a variety of bugs that were causing missing records. The core problems all appear to be fixed, though there is an outstanding problem with tombstones not being completely canceled. A very small number are appearing in the wrong order during the static structure test.
Diffstat (limited to 'include/query')
-rw-r--r--include/query/rangequery.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/include/query/rangequery.h b/include/query/rangequery.h
index ad5b767..c44f5d7 100644
--- a/include/query/rangequery.h
+++ b/include/query/rangequery.h
@@ -84,11 +84,11 @@ public:
* roll the pointer forward to the first record that is
* greater than or equal to the lower bound.
*/
- while(ptr->rec.key < p->lower_bound) {
+ while(ptr < shard->get_data() + s->stop_idx && ptr->rec.key < p->lower_bound) {
ptr++;
}
- while (ptr->rec.key <= p->upper_bound && ptr < shard->get_data() + s->stop_idx) {
+ while (ptr < shard->get_data() + s->stop_idx && ptr->rec.key <= p->upper_bound) {
records.emplace_back(*ptr);
ptr++;
}
@@ -152,6 +152,7 @@ public:
} else {
auto& cursor = cursors[tmp_n - now.version - 1];
if (!now.data->is_tombstone()) output.push_back(cursor.ptr->rec);
+
pq.pop();
if (advance_cursor<Wrapped<R>>(cursor)) pq.push(cursor.ptr, now.version);