From 7bed50185d3e114381043b8fdbe5c748a5c9a490 Mon Sep 17 00:00:00 2001
From: Douglas Rumbaugh <dbr4@psu.edu>
Date: Mon, 17 Jul 2023 16:10:18 -0400
Subject: VPTree: added fixme for tombstone handling in the hashtable

---
 include/shard/VPTree.h | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

(limited to 'include')

diff --git a/include/shard/VPTree.h b/include/shard/VPTree.h
index 6a976f7..7376d4c 100644
--- a/include/shard/VPTree.h
+++ b/include/shard/VPTree.h
@@ -194,9 +194,14 @@ private:
     }
 
     void build_map() {
-
         for (size_t i=0; i<m_reccnt; i++) {
-            m_lookup_map.insert({m_data[i].rec, i});
+          // FIXME: Will need to account for tombstones here too. Under
+          // tombstones, it is technically possible for two otherwise identical
+          // instances of the same record to exist within the same shard, so
+          // long as one of them is a tombstone. Because the table is currently
+          // using the unwrapped records for the key, it isn't possible for it
+          // to handle this case right now.
+          m_lookup_map.insert({m_data[i].rec, i});
         }
     }
 
-- 
cgit v1.2.3