diff options
| author | Douglas Rumbaugh <dbr4@psu.edu> | 2023-07-17 16:10:18 -0400 |
|---|---|---|
| committer | Douglas Rumbaugh <dbr4@psu.edu> | 2023-07-17 16:10:18 -0400 |
| commit | 7bed50185d3e114381043b8fdbe5c748a5c9a490 (patch) | |
| tree | 1bcdee7fa9c52f70370f92783008c8af3a844d64 /include/shard | |
| parent | 72bdba182d24ec8fd93d1d2b9bbe54aa57ff0e5d (diff) | |
| download | dynamic-extension-7bed50185d3e114381043b8fdbe5c748a5c9a490.tar.gz | |
VPTree: added fixme for tombstone handling in the hashtable
Diffstat (limited to 'include/shard')
| -rw-r--r-- | include/shard/VPTree.h | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/include/shard/VPTree.h b/include/shard/VPTree.h index 6a976f7..7376d4c 100644 --- a/include/shard/VPTree.h +++ b/include/shard/VPTree.h @@ -194,9 +194,14 @@ private: } void build_map() { - for (size_t i=0; i<m_reccnt; i++) { - m_lookup_map.insert({m_data[i].rec, i}); + // FIXME: Will need to account for tombstones here too. Under + // tombstones, it is technically possible for two otherwise identical + // instances of the same record to exist within the same shard, so + // long as one of them is a tombstone. Because the table is currently + // using the unwrapped records for the key, it isn't possible for it + // to handle this case right now. + m_lookup_map.insert({m_data[i].rec, i}); } } |